[9] RFR(S): 8048721: -XX:+PrintCompilation prints negative bci for non entrant OSR methods

Tobias Hartmann tobias.hartmann at oracle.com
Tue Jul 1 10:48:09 UTC 2014


Hi,

please review the following patch for JDK-8048721.

Bug: https://bugs.openjdk.java.net/browse/JDK-8048721
Webrev: http://cr.openjdk.java.net/~thartmann/8048721/webrev.00/

*Problem*
The VM option -XX:+PrintCompilation prints a negative bytecode index for 
not entrant OSR nmethods. The problem is that in 
nmethod::make_not_entrant_or_zombie(..) the _entry_bci is invalidated 
(i.e. set to InvalidOSREntryBci == -2) by invalidate_osr_method(..) and 
log_state_change(..) is called afterwards, printing the invalidated entry.

*Solution
*Because reordering the methods in 
nmethod::make_not_entrant_or_zombie(..) is not easily possible due to 
thread safety, I changed the implementation log_state_change(..) and 
dependent methods to take the entry bci as parameter. The entry bci is 
saved prior to invalidation and used for printing afterwards.

*Testing*
JPRT

Thanks,
Tobias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140701/664afde4/attachment.html>


More information about the hotspot-compiler-dev mailing list