RFR (S): 8048882: Some regression tests are not robust with VM output
Vladimir Kozlov
vladimir.kozlov at oracle.com
Thu Jul 17 19:33:22 UTC 2014
Good.
Thanks,
Vladimir
On 7/17/14 11:56 AM, Igor Ignatyev wrote:
> Vladimir,
>
> as Pavel mentioned in his email, he reproduced the original failure:
>>> Verified that it still reproduces the original issue the regression
>>> test was made for.
>
> Thanks,
> Igor
>
> On 07/17/2014 10:07 PM, Vladimir Kozlov wrote:
>> Thank you, Pavel, for this cleaning up.
>> Changes looks fine to me. The only question is - did you reproduced the
>> original failure with modified test?
>>
>> Thanks,
>> Vladimir
>>
>> On 7/17/14 10:08 AM, Pavel Punegov wrote:
>>> Please review the next change for the test bug
>>> webrev:
>>> http://cr.openjdk.java.net/~iignatyev/ppunegov/8048882/webrev.00/
>>> <http://cr.openjdk.java.net/%7Eiignatyev/ppunegov/8048882/webrev.00/>
>>>
>>> Problem:
>>> The test used shell script that diffs output got form the test. If
>>> there are warning, test fails.
>>>
>>> Fix:
>>> Remove shell script. Make compare of the test results inside the
>>> java-file.
>>> Also, I have fixed indentation and code style to be more Java-style.
>>>
>>> Testing:
>>> Locally and JPRT.
>>> Verified that it still reproduces the original issue the regression
>>> test was made for.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8048882
>>>
More information about the hotspot-compiler-dev
mailing list