RFR (S) : 8032449 : Get rid of JMX in test/compiler/whitebox/CompilerWhiteBoxTest.java

[Igor Ignatyev]

Vladimir, thanks for review.

during testing, I've found a problem: if a flag doesn't exist, 
WhiteBox::getVMFlag() will throw j.u.NoSuchElementException. I fixed it 
by replacing Optional::get() w/ Optional::orElse(null)

webrev: http://cr.openjdk.java.net/~iignatyev/8032449/webrev.01/

retested locally and in JPRT, no failures except JDK-7076820 (JDK-8051337).

Igor

On 07/18/2014 02:37 AM, Vladimir Kozlov wrote:
> Looks nice.
>
> Thanks,
> Vladimir
>
> On 7/17/14 3:18 PM, Igor Ignatyev wrote:
>> webrev: http://cr.openjdk.java.net/~iignatyev/8032449/webrev.00/
>> 69 lines changed: 27 ins; 34 del; 8 mod;
>>
>> Hi all,
>>
>> Please review the patch which removes dependency on JMX from several
>> tests (replacing usage of 'c.s.m.HotSpotDiagnosticMXBean' w/
>> WhiteBox::get*VMFlag) and removes them from needs_compact3 group.
>>
>> I also moved @ignore tags after @library in the tests quarantined by
>> 8047996. I needed this to verify that my changes don't break them, w/o
>> that, jtreg can't start them and counts as errors even w/ -ignore:run
>> due to:
>>> Parse Exception: `@library' must appear before first `@run'
>>
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8032449
>> testing: :compact1 w/ -ignore:run on compact1-linux-i586; ./compiler in
>> JPRT