RFR (S) : 8051484 : Test compiler/6932496/Test6932496.java failed to compile after JDK-8011044: 1.5 is no longer supported

[Igor Ignatyev]

updated webrev: http://cr.openjdk.java.net/~iignatyev/8051484/webrev.01/

On 07/23/2014 12:47 AM, Vladimir Kozlov wrote:
> On 7/22/14 1:04 PM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8051484/webrev.00/
>> 139 lines changed: 126 ins; 2 del; 11 mod
>>
>> Hi all,
>>
>> Please review patch:
>>
>> Problem:
>> JDK-8011044 removed support of javac 1.5  sources and target platform,
>> but compiler/6932496/Test6932496.java uses it to generate jtr, ret
>> instructions
>>
>> Fix:
>> the test was rewritten by using ASM
>
> Looks good. I think it would be better if you put whole Test class in
> one comment before generateTestClass() in addition to spreading comments
> in the code.
sure, added.
>
>>
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8051484
>> testing:
>>   - locally
>>   - I'm not able to reproduce 6932496 on 1.7.0-b80 neither by the
>> original version nor the new one, since  but I reproduced it on jdk9 w/o
>> the fix for 8051484, src/share/vm/c1/c1_LIR.cpp:
>
> You mean without part of 6932496 fix. Right?
yeap, I mean 6932496.
> Thank you for reproducing the failure with new test version.
>
> Thanks,
> Vladimir
>
>>
>>> LIR_Opr LIR_OprFact::value_type(ValueType* type) {
>> ...
>>>   case addressTag: // return
>>> LIR_OprFact::addressConst(type->as_AddressConstant()->value());
>>>   case intTag    : return
>>> LIR_OprFact::intConst(type->as_IntConstant()->value());
>>
>>> LIR_Opr LIR_OprFact::dummy_value_type(ValueType* type) {
>> ...
>>>     case addressTag://return LIR_OprFact::addressConst(0);
>>>     case intTag:    return LIR_OprFact::intConst(0);
>>
>>