[8u backport] RFR(XS): 8051803 [parfait] warnings from b114 for hotspot.src.share.vm

[Vladimir Kozlov]

Changes are good.

David, you should use only original bug id in Subject and in the request 
text (nobody care about backport bug id). Also you have to point jdk9 
changeset:

http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/de9cd35a3d1f

And you should say if you need to change the fix for 8u or it is applied 
(hg export/import) cleanly. And backport it using hg export/import.

Thanks,
Vladimir

On 7/23/14 12:43 PM, David Chase wrote:
> Summary: it’s a parfait warning, where convoluted and perhaps delicate logic ensures that a NULL could “never” appear.
> Fix is to insert a null check and return the “nothing here” result (false) which (a) should never occur anyhow and
> (b) is safe and consistent behavior.
>
> webrev: http://cr.openjdk.java.net/~drchase/8051803/webrev.00/
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8051803
>
> backport of: https://bugs.openjdk.java.net/browse/JDK-8028037
>
> old review discussion: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-March/013684.html
>
> testing: local jtreg
>
> David
>