[9] RFR(XS): 8033145: Runtime1::arraycopy_count_address uses wrong _oop_arraycopy_cnt variable

[Christian Thalinger]

Looks good.  Thanks.

On Jun 6, 2014, at 7:56 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:

> Hi Chris,
> 
> thanks for the review.
> 
>> If you are renaming one of the variables you should renamed all of them.  Otherwise it’s inconsistent.
> 
> Done. New webrev:
> 
> http://cr.openjdk.java.net/~thartmann/8033145/webrev.01/
> 
> Best,
> Tobias
> 
>> 
>> On Jun 5, 2014, at 11:33 PM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
>> 
>>> Hi,
>>> 
>>> please review the following patch for bug 8033145.
>>> 
>>> Problem
>>> The method Runtime1::arraycopy_count_address(..) returns the address of Runtime::_oop_arraycopy_cnt instead of the the file static variable _oop_arraycopy_cnt. The same applies to Runtime1::print_statistics(..). As a result the output generated by the PrintC1Statistics flag is wrong.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8033145
>>> 
>>> Solution
>>> The file static variable _oop_arraycopy_cnt is renamed to _oop_arraycopy_stub_cnt.
>>> 
>>> Webrev: http://cr.openjdk.java.net/~thartmann/8033145/webrev.00/
>>> 
>>> Tests
>>> JPRT
>>> 
>>> Thanks,
>>> Tobias
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140606/037d4e74/attachment.html>