RFR(XXS): 8040244 compiler/whitebox/IsMethodCompilableTest.java fails

[Christian Thalinger]

On Jun 9, 2014, at 9:06 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> That confuses me.  -Xcomp should honor CompileCommand.  A quick test shows this behavior:
> 
> $ java -Xcomp -XX:+PrintCompilation -XX:CompileCommand=compileonly,java.lang.String::hashCode -version
> CompilerOracle: compileonly java/lang/String.hashCode
>      57    1    b  4       java.lang.String::hashCode (55 bytes)
> java version "1.9.0-ea"
> Java(TM) SE Runtime Environment (build 1.9.0-ea-b07)
> Java HotSpot(TM) 64-Bit Server VM (build 25.0-b62, compiled mode)
> 
> Why does it fix the problem then?

Reading the bug’s comments I think I get it:

"The test uses reflection to get the method being tested. -Xcomp makes the reflecting method inline the test method. That method is never invalidated. The test method never gets any invocations and never ends up as a c2.compile.”

> 
> On Jun 9, 2014, at 1:45 AM, Nils Eliasson <nils.eliasson at oracle.com> wrote:
> 
>> Hi,
>> 
>> Please review this patch for bug 8040244.
>> 
>> Summary: The test uses CompileCommand compileonly and breaks when forced to run with Xcomp. Add -Xmixed to prevent -Xcomp from being used.
>> 
>> webrev: http://cr.openjdk.java.net/~neliasso/8040244/webrev.01/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8040244
>> 
>> Regards,
>> Nils
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140609/99cd62d2/attachment.html>