RFR(XS) : 8044575 : testlibrary_tests/whitebox/vm_flags/UintxTest.java failed: assert(!res || TypeEntriesAtCall::arguments_profiling_enabled()) failed: no profiling of arguments

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Tue Jun 10 15:08:37 UTC 2014


Looks good to me.


On 10.06.2014 18:48, Igor Ignatyev wrote:
> Hi GC-people,
>
> Could some of you look at the change?
>
> Igor
>
> On 06/03/2014 01:55 AM, Vladimir Kozlov wrote:
>> Hi Igor,
>>
>> Looks good to me but I would ask GC group to comment on this change.
>>
>> Thanks,
>> Vladimir
>>
>> On 6/2/14 1:49 PM, Igor Ignatyev wrote:
>>> webrev: http://cr.openjdk.java.net/~iignatyev/8044575/webrev.00/
>>> 4 lines changed: 0 ins; 2 del; 2 mod;
>>>
>>> Hi all,
>>>
>>> Please review patch:
>>>
>>> Problem:
>>> the test changes 'TypeProfileLevel' via WhiteBox during execution, but
>>> 'TypeProfileLevel' isn't supposed to be changed and there's the asserts
>>> based on that. the test w/ '-Xcomp and -XX:-TieredCompilation' triggers
>>> one of these asserts.
>>>
>>> Fix:
>>> - as a flag to change, the test uses 'VerifyGCStartAt' instead of
>>> 'TypeProfileLevel'. 'VerifyGCStartAt' is safe to change during 
>>> execution
>>> - removed 'System.out.println' which was left by accident
>>>
>>> jbs: https://bugs.openjdk.java.net/browse/JDK-8044575
>>> testing: failing tests locally w/ different flags combinations



More information about the hotspot-compiler-dev mailing list