RFR(XXS) : 8044742 : testlibrary_tests/whitebox/vm_flags/BooleanTest.java NoClassDefFoundError: com/oracle/java/testlibrary/JDKToolFinder

[Igor Ignatyev]

http://cr.openjdk.java.net/~iignatyev/8044742/webrev.00/
1 line changed: 0 ins; 0 del; 1 mod;

Hi all,

Please review patch:

Problem:
the test uses @library, but don't specify @build for all needed classes. 
what leads to intermittent failures.
In 8043915, Katja fixed this issues, but 
'testlibrary_tests/whitebox/vm_flags/' were integrated after.

Fix:
all used classes are specified in @build

jbs: https://bugs.openjdk.java.net/browse/JDK-8044742
testing: failing test in the same configuration as in nightly
-- 
Igor

> On 05/28/2014 03:58 PM, Yekaterina Kantserova wrote:
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> webrev: http://cr.openjdk.java.net/~ykantser/8043915/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8043915
>>
>> When using @library in a JTreg test even @build need to be specify for
>> all library files used by the test. If @build is not specified it can
>> lead to intermittent failures when for example running tests
>> concurrently, since javac implicit compilation and @library and
>> -concurrency don't play well together.
>>
>> Verified locally.
>>
>> Thanks,
>> Katja