[9] RFR(XXS): 8043158: Crash in CodeSweeperSweepNoFlushTest in CompileQueue::free_all()

[Albert]

Hi Chris,

thanks for looking at this. We use the lock if:
1) we wait for a compilation task to complete (background compilation 
disabled).
2) we mark a compilation task to be complete (background compilation 
disabled).

I don't think that a deadlock is possible.

Best,
Albert

On 06/06/2014 04:41 PM, Christian Thalinger wrote:
> Who else can hold that lock?  Is there a dead-lock possibility?
>
> On Jun 6, 2014, at 1:17 AM, Albert <albert.noll at oracle.com> wrote:
>
>> Hi,
>>
>> could I get reviews for this small patch?
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8043158
>>
>> Problem:
>> In CompileQueue::free_all() we call notify() on a compile task although we do not own the
>> lock of the compile task object.
>>
>> Solution:
>> Acquire lock before calling notify()
>>
>> Testing:
>> Failing test case
>>
>> Webrev:
>> http://cr.openjdk.java.net/~anoll/8043158/webrev.00/
>>
>> Many thanks in advance,
>> Albert