RFR: 8041794: remove bytecodes_<arch>.{cpp,hpp} files

Christian Thalinger christian.thalinger at oracle.com
Tue Jun 17 17:37:49 UTC 2014


Looks good.  Thanks for picking that one up.

On Jun 17, 2014, at 9:08 AM, Lev Priima <lev.priima at oracle.com> wrote:

> Hi,
> 
> Problem:
> We don't have any platform specific bytecodes and these files are empty:
> hs-comp/hotspot$ find -name bytecodes_\* | grep -v "/.hg/"
> ./src/cpu/ppc/vm/bytecodes_ppc.cpp
> ./src/cpu/ppc/vm/bytecodes_ppc.hpp
> ./src/cpu/sparc/vm/bytecodes_sparc.cpp
> ./src/cpu/sparc/vm/bytecodes_sparc.hpp
> ./src/cpu/x86/vm/bytecodes_x86.cpp
> ./src/cpu/x86/vm/bytecodes_x86.hpp
> ./src/cpu/zero/vm/bytecodes_zero.cpp
> ./src/cpu/zero/vm/bytecodes_zero.hpp
> 
> .hpp's are only included in bytecodes.hpp:
> hs-comp/hotspot$ grep -rn \"bytecodes_\* src
> src/share/tools/IdealGraphVisualizer/Data/src/com/sun/hotspot/igv/data/serialization/Parser.java:79: public static final String BYTECODES_ELEMENT = "bytecodes";
> src/share/vm/interpreter/bytecodes.hpp:292:# include "bytecodes_x86.hpp"
> src/share/vm/interpreter/bytecodes.hpp:295:# include "bytecodes_sparc.hpp"
> src/share/vm/interpreter/bytecodes.hpp:298:# include "bytecodes_zero.hpp"
> src/share/vm/interpreter/bytecodes.hpp:301:# include "bytecodes_arm.hpp"
> src/share/vm/interpreter/bytecodes.hpp:304:# include "bytecodes_ppc.hpp"
> 
> All bytecodes_<arch>.cpp files have empty implementations of their functions.
> Function:
> src/share/vm/interpreter/bytecodes.hpp:335: static Code pd_base_code_for(Code code);
> with empty implementation in each platform-specific bytecodes_* file is never called.
> 
> 
> Solution:
> I've removed these files and include directives of them. Also I removed two function declarations and one call-statement of pd_initialize().
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8041794
> 
> Webrev:
> http://cr.openjdk.java.net/~iignatyev/lpriima/8041794/webrev.00/
> 
> Testing:
> Jprt build and tests
> 
> -- 
> Lev
> 



More information about the hotspot-compiler-dev mailing list