[9] RFR(XS): 8008321: compile.cpp verify_graph_edges uses "bool" as "int"

[Tobias Hartmann]

Thank you, Albert.

Tobias

On 18.06.2014 11:26, Albert wrote:
>
> On 06/18/2014 10:47 AM, Tobias Hartmann wrote:
>> Hi Albert,
>>
>> thanks for the suggestion. I adapted the fix.
>>
>> New webrev: http://cr.openjdk.java.net/~thartmann/8008321/webrev.01/
>>
> That looks good to me (Not a reviewer).
>
> Albert
>> Best,
>> Tobias
>>
>> On 18.06.2014 10:30, Albert wrote:
>>> Hi Tobias,
>>>
>>> another way to fix this would be to stick with the bool, but use it 
>>> differently:
>>> dead_nodes seems to be only used to print the following line once:
>>>
>>>  tty->print_cr("*** Dead nodes reachable via DU edges:");
>>>
>>> So how about this:
>>>
>>> bool print = true;
>>> ...
>>> if (print) {
>>>       tty->print_cr("*** Dead nodes reachable via DU edges:");
>>>      print = false;
>>> }
>>>
>>>
>>> This is only a suggestion. Your solution looks fine too (Not a 
>>> reviewer).
>>>
>>>
>>> Best,
>>> Albert
>>>
>>> On 06/18/2014 10:04 AM, Tobias Hartmann wrote:
>>>> Hi,
>>>>
>>>> please review the following small patch that fixes the type of the 
>>>> dead nodes counter in Compile::verify_graph_edges(..).
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8008321
>>>> Webrev: http://cr.openjdk.java.net/~thartmann/8008321/webrev.00/
>>>> Testing: JPRT
>>>>
>>>> Thanks,
>>>> Tobias
>>>
>>
>