RFR(XXS): 8046286: assert: Do not add task if compilation is turned off forever

Albert albert.noll at oracle.com
Fri Jun 20 10:45:17 UTC 2014


Hi all,

could I get reviews for this very small patch.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8046286

Problem:
CodeSweeperSweepNoFlushTest fails with the following assert:
assert(!CompileBroker::is_compilation_disabled_forever()) failed: Do not 
add task if compilation is turned off forever).

Solution:
The assert is unnecessary (there is a potential problem for blocking 
compiles and blocking compiles are
already handled (JDK-8040798)) and missleading 
(is_compilation_disabled_forever() could be just set asynchronously after
the assert). So the proposed solution is to remove the assert.

webrev:
http://cr.openjdk.java.net/~anoll/8046286/webrev.00/

Thanks,
Albert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140620/e35feb06/attachment.html>


More information about the hotspot-compiler-dev mailing list