[9] RFR(XS): 8033332: missing types in TemplateInterpreterGenerator::generate_result_handler_for

[Albert]

That looks good to me (not a Reviewer).

Best,
Albert

On 06/24/2014 07:51 AM, Tobias Hartmann wrote:
> Thank you, Igor.
>
> Best,
> Tobias
>
> On 21.06.2014 05:57, Igor Veresov wrote:
>> Look good.
>>
>> igor
>>
>> On Jun 18, 2014, at 6:31 AM, Tobias Hartmann 
>> <tobias.hartmann at oracle.com <mailto:tobias.hartmann at oracle.com>> wrote:
>>
>>> Hi,
>>>
>>> please review the following patch for 8033332.
>>>
>>> *Problem*
>>> The 32 bit version of 
>>> TemplateInterpreterGenerator::generate_result_handler_for(..) does 
>>> not handle the basic types T_LONG and T_VOID. Currently it does not 
>>> fail because AbstractInterpreter::BasicType_as_index(..) returns the 
>>> same index (4) for T_INT, T_LONG and T_VOID and therefore 
>>> TemplateInterpreterGenerator::generate_all(..) invokes the method 
>>> only once for T_INT. This can cause problems if the ordering of 
>>> types changes.
>>>
>>> *Solution*
>>> Add missing case statements for T_LONG and T_VOID to 
>>> generate_result_handler_for(..).
>>>
>>> *Testing*
>>> JPRT
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8033332
>>> Webrev: http://cr.openjdk.java.net/~thartmann/8033332/webrev.00/
>>>
>>> Thanks,
>>> Tobias
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140625/a0373d65/attachment.html>