RFR (XS): 8035887: VM crashes trying to force inlining the recursive call

[Christian Thalinger]

Looks good.

On Feb 28, 2014, at 9:13 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

> Chris, David, thanks for review.
> 
> Yes, that's an overlook on my side.
> 
> Updated webrev:
> http://cr.openjdk.java.net/~vlivanov/8035887/webrev.02/
> 
> I use empty string as a default, because NULL has special meaning for print_inlining. I hope we'll clean this up some day...
> 
> Best regards,
> Vladimir Ivanov
> 
> On 2/28/14 8:22 PM, David Chase wrote:
>> 
>> On 2014-02-27, at 1:01 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> 
>>> !     const char* msg;
>>> +     if (callee->force_inline())  msg = "force inline by annotation";
>>> +     if (callee->should_inline()) msg = "force inline by CompileOracle";
>>> +     print_inlining(callee, msg);
>>> 
>>> We shouldn’t leave msg uninitialized.  I know that it is not a problem with the code as it is now but it might be in the future.
>> 
>> And Parfait will complain right now.
>> 
>>