RFR(M): 8036146: make CPP interpreter build again

[Volker Simonis]

I was just told that defining PPC64 explicitly on the command line
will implicitly define PPC (see src/share/vm/utilities/macros.hpp). So
from our PPC64 port perspective your change looks fine as it currently
is.

You'll probably only want to change PPC to PPC64 if you have the CPP
interpreter for your internal PPC32 port and it doesn't support
'_last_Java_fp'.

Thanks,
Volker


On Tue, Mar 4, 2014 at 2:34 PM, Volker Simonis <volker.simonis at gmail.com> wrote:
> Hi Roland,
>
> I suppose you need the following change in bytecodeInterpreter.cpp:
>
> ! #if !defined(ZERO) && defined(PPC)
>
> because _last_Java_fp isn't defined for sparc and x86.
>
> But do you really mean PPC or PPC64? We use '_last_Java_fp' for PPC64
> (see src/cpu/ppc/vm/bytecodeInterpreter_ppc.hpp) so this should at
> leaset read:
>
> ! #if !defined(ZERO) && (defined(PPC) || defined(PPC64))
>
> If you don't use the CPP interpreter for your closed PPC32 port you
> could probably just change the PPC to PPC64.
>
> Thanks,
> Volker
>
> On Mon, Mar 3, 2014 at 11:12 PM, Roland Westrelin
> <roland.westrelin at oracle.com> wrote:
>> I’m working on a fix that required some changes to the CPP interpreter so I got it building again on sparc and x86:
>>
>> http://cr.openjdk.java.net/~roland/8036146/webrev.00/
>>
>> But it doesn’t run (java -version crashes). Should I push the build fixes anyway?
>>
>> Roland.