RFR (XS): 8028037: "[parfait] warnings from b114 for hotspot.src.share.vm "

[David Chase]

It's a trivial change, but I'm rerunning jtreg anyhow:

new fix: http://cr.openjdk.java.net/~drchase/8028037/webrev.01/


On 2014-03-07, at 12:08 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> David,
> 
> Next line is not needed, I think it was there because some time ago proj_out() returned basic Node* type. as_Proj() is simple cast and assert. And that is already done in proj_out() method now.
> 
> other_proj = other_proj -> as_Proj();
> 
> Also don't use spaces around '->' in your changes.
> 
> Thanks,
> Vladimir
> 
> On 3/7/14 6:50 AM, David Chase wrote:
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028037
>> Fix: http://cr.openjdk.java.net/~drchase/8028037/webrev.00/
>> 
>> Testing: local jtreg.
>> 
>> The fix addresses half of the bug, inserting a null check to keep Parfait happy.  The logic to ensure that the null cannot happen is a little convoluted and split across two places.
>> 
>> The other half of the bug is addressed (separately, by other people) with an addition to the Parfait configuration files so that report_vm_error is treated as an exit (which it is except for certain cases of debugging).
>> 
>> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140307/b0bc30ca/signature.asc