[9] RFR(S): 8042431: compiler/7200264/TestIntVect.java fails with: Test Failed: AddVI 0 < 4

[Albert]

Hi Niclas,

thanks for looking at this. Please see comment inline.
On 05/06/2014 03:04 PM, Niclas Adlertz wrote:
> Hi Albert,
>
> Inside src/share/vm/runtime/arguments.cpp:
> +   // We should not come here. However, we also do not fail the VM, 
> since this is a not-critical error.
> +   assert (false, "Missed configuration to set the minimum number of 
> compiler threads.");
> +   // Return 2, since this works with all configurations on all 
> platforms.
> +   return 2;
>
> That is dead code, and we can remove it.
> If none of the cases 1, 2 or 3 are true, we will always enter case 4.
That code is there to make sure (in case someone makes changes to that 
function)
that the default return value is 2, since this works for all platforms.

Do you think that leaving a comment is good enough (or not even that)?

>
> Kind Regards,
> Niclas Adlertz
>
> On 05/06/2014 02:43 PM, Albert wrote:
>> Hi all,
>>
>> could I get reviews for this patch?
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8042431
>>
>> Problem:
>> The minimum number of compiler threads is set incorrectly.
>>
>> Solution:
>> Define a new function 'get_min_number_of_compiler_threads()' that
>> determines the minimum number of compiler threads  for a particular
>> platform/configuration.
>>
>> Testing:
>> Failing test case; zero; -XX:-TieredCompilation -XX:CICompilerCount=1
>>
>> Webrev:
>> http://cr.openjdk.java.net/~anoll/8042431/webrev.00/
>>
>> Many thanks in advance,
>> Albert
>>
>>