RFR(XS): 8043063: Code aging should allocate MethodCounters when flushing a method

[Igor Veresov]

Thanks, Vladimir!

igor

On May 13, 2014, at 7:01 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> On 5/13/14 6:14 PM, Igor Veresov wrote:
>> I don’t think it hurts to make sure they exist at this point in the sweeper. In addition to that, only AdvancedTieredPolicy needs them to be present if a method in the queue. Other policies could work fine without MCs, and for example with Xcomp. It would be needless to allocate MCs in that case.
> 
> Okay. Changes are good.
> 
> thanks,
> Vladimir
> 
>> 
>> igor
>> 
>> On May 13, 2014, at 6:00 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>>> I think this should be fixed in general (8043061). We should allocate MethodCounters at least when we create a compilation task.
>>> 
>>> Thanks,
>>> Vladimir
>>> 
>>> On 5/13/14 5:45 PM, Igor Veresov wrote:
>>>> In some edge cases we may not have MethodCounters allocated for a method that was compiled, like with -Xcomp.
>>>> So with code aging we need to allocate MCs when we are flushing the method to set up the aging counter.
>>>> 
>>>> Webrev: http://cr.openjdk.java.net/~iveresov/8043063/webrev.00/
>>>> 
>>>> Thanks!
>>>> igor
>>>> 
>>