RFR (S): JDK-8038924: Test bit-instructions fails with unexpected exit value on sparc

[Filipp Zhinkin]

Vladimir, thank you.

Filipp.

On 05/22/2014 09:53 PM, Vladimir Kozlov wrote:
> Very good.
>
> Thanks,
> Vladimir
>
> On 5/22/14 10:46 AM, Filipp Zhinkin wrote:
>> Vladimir,
>>
>> On 05/21/2014 10:40 PM, Vladimir Kozlov wrote:
>>> I am okay with changes. I would only suggest to add comment in tests
>>> to list what command line will be used when forked VM is executed.
>> I agree, it will save a lot of time for everyone who need look at tests'
>> sources.
>>
>> Here is an updated webrev:
>> http://cr.openjdk.java.net/~iignatyev/fzhinkin/8038924/webrev.01/
>>
>> Thanks,
>> Filipp.
>>>
>>> thanks,
>>> Vladimir
>>>
>>> On 5/22/14 11:29 AM, Filipp Zhinkin wrote:
>>>> Vladimir,
>>>>
>>>> so you're OK with this change?
>>>>
>>>> I've filed an RFE https://bugs.openjdk.java.net/browse/JDK-8043674 for
>>>> allowing execution of correctness tests on all platforms.
>>>>
>>>> Thanks,
>>>> Filipp.
>>>>
>>>> On 05/21/2014 10:17 PM, Vladimir Kozlov wrote:
>>>>> Not surprisingly :) I missed that it runs only with -version. It is
>>>>> hard to see which options are used. Non of these tests list 
>>>>> '-version'
>>>>> even in a comment.
>>>>>
>>>>> I agree that if you fork the same VM (server or client, 32-bit or
>>>>> 64-bit) and run it with -version flag you don't need to pass all CL
>>>>> options.
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 5/21/14 6:23 AM, Filipp Zhinkin wrote:
>>>>>> Vladimir,
>>>>>>
>>>>>> sorry for a late response.
>>>>>>
>>>>>> On 05/13/2014 11:21 PM, Vladimir Kozlov wrote:
>>>>>>> On 5/13/14 11:49 AM, Filipp Zhinkin wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> please review fix forJDK-8038924.
>>>>>>>
>>>>>>> Filipp, please, provide the link to the bug report in you RFR.
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8038924
>>>>>>
>>>>>> Sorry for that, I'l take it in mind for future RFRs.
>>>>>>>
>>>>>>>>
>>>>>>>> CLI tests on BMI-related options previously took all externally
>>>>>>>> passed
>>>>>>>> VM options,
>>>>>>>> add options that should be tested and launch new VM with such
>>>>>>>> combination of options.
>>>>>>>>
>>>>>>>> Unfortunately, some options like IgnoreUnrecognizedVMOptions, can
>>>>>>>> affect
>>>>>>>> processing of tested flags and in such case tests fail.
>>>>>>>>
>>>>>>>> I've updated these tests so now they do not use externally passed
>>>>>>>> options.
>>>>>>>
>>>>>>> I don't think it is right solution. Some external flags could be
>>>>>>> important (DeoptimizeALot for example).
>>>>>>>
>>>>>>> You can add -XX:-IgnoreUnrecognizedVMOptions to tests which you
>>>>>>> expect
>>>>>>> to fail (on platforms which does not have the feature). It will
>>>>>>> nullify this flag passed from CL.
>>>>>> In general I agree with that point - tests should be able to use as
>>>>>> much
>>>>>> externally passed options as possible.
>>>>>> However, in this particular case I believe that it would be 
>>>>>> better to
>>>>>> ignore such options, because these tests only launch a new VM with
>>>>>> tests
>>>>>> options and '-version' flag,
>>>>>> so we'll not be able to catch issues that we can't find with 
>>>>>> other BMI
>>>>>> tests. And if CLI tests will not use externally passed options it 
>>>>>> will
>>>>>> be easier to maintain it.
>>>>>>
>>>>>> Note that other BMI-related tests use all externally passed
>>>>>> options, so
>>>>>> we can catch any issues related to JVM behaviour using it.
>>>>>>
>>>>>> So I think that it will be better to avoid usage of externally 
>>>>>> passed
>>>>>> options in CLI-tests and update compiler/intrinsics/bmi tests to
>>>>>> run it
>>>>>> on all platforms.
>>>>>>
>>>>>> Thanks,
>>>>>> Filipp.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Vladimir
>>>>>>>
>>>>>>>> Also, I've fix silly issue with String::format in
>>>>>>>> BMICommandLineOptionTestBase.java.
>>>>>>>>
>>>>>>>> Webrev:
>>>>>>>> http://cr.openjdk.java.net/~iignatyev/fzhinkin/8038924/webrev.00/
>>>>>>>> Testing: manual and automated.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Filipp.
>>>>>>
>>>>
>>