[9] RFR(M): 8062011: JT_HS/compiler/7068051 uses jre/lib/javaws.jar

[Tatiana Pivovarova]

Hi Vladimir

And thanks for this review!

Tatiana


On 11/07/2014 07:23 PM, Vladimir Kozlov wrote:
> Thank you for clarification, Tatiana
>
> Changes are good.
>
> Thanks,
> Vladimir
>
> On 11/7/14 5:58 AM, Tatiana Pivovarova wrote:
>> Hi Vladimir,
>>
>> Thank you for your review.
>>
>> On 11/07/2014 05:45 AM, Vladimir Kozlov wrote:
>>> Hi Tatiana,
>>>
>>> I assume you reproduced original problem with old JDK and your new 
>>> test? Please, say that in "Testing:" so that I
>>> don't need to ask it each time.
>> I reproduced this bug in jdk 7 b147 (test failed). In jdk 7 b148 and 
>> latest version test passed.
>>
>>>
>>> You used Test7068051.java 100 times to create foo.jar. It is fine if 
>>> it still reproduces the problem.
>> When I use less than 78-80 files test doesn't reproduce, so I chose 
>> empirical number "100".
>>
>> Thanks,
>> Tatiana.
>>>
>>> Originally it was suggested to use classes from rt.jar but I 
>>> switched to javaws.jar because it was smaller and still
>>> reproduced the problem.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 11/6/14 1:41 AM, Tatiana Pivovarova wrote:
>>>> Hi all,
>>>>
>>>> please review the patch
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8062011
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~iignatyev/tpivovarova/8062011/webrev.00/
>>>>
>>>> Problem:
>>>> test/compiler/7068051 uses jre/lib/javaws.jar which is removed in 
>>>> jigsaw M2
>>>>
>>>> Solution:
>>>> We create .jar file by ourselves.
>>>>
>>>> Testing:
>>>> Manual
>>>>
>>>> Thanks,
>>>> Tatiana
>>