[9] RFR(L): 8062854: move compiler jtreg test to corresponding subfolders and use those in TEST.groups
Zoltán Majó
zoltan.majo at oracle.com
Thu Nov 13 13:32:43 UTC 2014
Hi,
please review the following patch.
Bug: https://bugs.openjdk.java.net/browse/JDK-8062854
Problem:
Currently, we list all short-running JTREG tests that we execute in JPRT
in the hotspot/test/TEST.groups file (using the test groups
hotspot_compiler_[1-3] and hotspot_compiler_closed).
The problem with this approach is that if we want to execute a new
(short-running) JTREG test in JPRT, the TEST.groups file must be updated
to execute the newly added JTREG test. Moreover, the current selection
of tests is based on a per-group time limit of 10 minutes (i.e., each
test group executes 10 minutes on the slowest JPRT platform available),
but it seems that a 15-minute limit is also tolerable.
Solution: Move all test directories of the form
hotspot/test/<numeric_bug_id> to "functionality-based" directories.
Each functionality-based directory contains tests related to a specific
functionality of the VM, for example: hotspot/test/compiler/c1,
hotspot/test/compiler/c2, and hotspot/test/compiler/codecache. In the
TEST.groups file we list only functionality-based directories, and not
individual tests. We also exclude long-running tests.
Webrev: http://cr.openjdk.java.net/~zmajo/8062854/webrev.00/
The webrev is large because a large number of directories was moved. The
test/TEST.groups file summarizes changes well.
Testing: JPRT
Before changes (group / #tests / execution time on solaris_sparcv9
cpus=6 parallelcount=6 cpufreqmhz=2848):
hotspot_compiler_1 / 73 / 9m16s
hotspot_compiler_2 / 60 / 9m50s
hotspot_compiler_3 / 69 / 13m32s
After changes (group / #tests / execution time on solaris_sparcv9 cpus=6
parallelcount=6 cpufreqmhz=2848):
hotspot_compiler_1 / 107 / 16m55s
hotspot_compiler_2 / 76 / 14m49s
hotspot_compiler_3 / 59 / 13m44s
All tests (also excluded ones) were executed on all platforms to check
if any configuration error has appeared due to reorganizing the
directory structure. All tests pass.
Thank you and best regards,
Zoltan
More information about the hotspot-compiler-dev
mailing list