RFR(S): 8064696: compiler/startup/SmallCodeCacheStartup.java doesn't check exit code

Tatiana Pivovarova tatiana.pivovarova at oracle.com
Thu Nov 20 08:35:16 UTC 2014


Hi Albert,
Thanks for review!

Tatiana

On 11/20/2014 08:30 AM, Albert Noll wrote:
> Hi Tatiana,
>
> this looks good to me as well (not a reviewer).
>
> Best,
> Albert
>
> On 11/19/2014 05:53 PM, Tatiana Pivovarova wrote:
>> Hi,
>>
>> please review this patch
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8064696
>> Webrev: 
>> http://cr.openjdk.java.net/~iignatyev/tpivovarova/8064696/webrev.00
>>
>> compiler/startup/SmallCodeCacheStartup.java starts a new process, but 
>> doesn't check its exit code.
>>
>> Fix:
>> - added check of exit code via OutputAnalizer
>> - removed recursion (call vm with option "-version" instead 
>> "SmallCodeCacheStartup")
>>
>> testing: Manually. As expected: fails in 8-b112 and passed in 8-b113 
>> (and latest 9-b40).
>>
>> Thanks,
>> Tatiana
>>
>



More information about the hotspot-compiler-dev mailing list