[9] RFR(S): 8060196: CodeHeap for 'non-nmethods' is full

[Tobias Hartmann]

Hi Albert,

On 13.10.2014 17:02, Albert Noll wrote:
> Hi Tobias,
>
> I would wait until 8046809 is reviewed. Doing modifications to a function that
> is being discussed to remove does not make sense.

Yes, I agree. I changed the webrev to only fix the output of the "code heap is 
full" message:

http://cr.openjdk.java.net/~thartmann/8060196/webrev.01/

I added a comment to the bug.

Thanks,
Tobias


> Best,
> Albert
>
> On 10/13/2014 04:57 PM, Tobias Hartmann wrote:
>> Hi Albert,
>>
>> On 13.10.2014 16:34, Albert Noll wrote:
>>> Hi Tobias,
>>>
>>> 8046809 (which is currently under review) removes that check. Does removing the
>>> check fix the bug?
>>
>> Yes, but the output (see 'CodeCache::report_codemem_full') is still wrong. Do
>> you think I should only fix the output and wait for your fix to remove the
>> 'is_full' check?
>>
>> Thanks,
>> Tobias
>>
>>> Best,
>>> Albert
>>>
>>> On 10/13/2014 03:02 PM, Tobias Hartmann wrote:
>>>> Hi,
>>>>
>>>> please review the following patch.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8060196
>>>> Webrev: http://cr.openjdk.java.net/~thartmann/8060196/webrev.00/
>>>>
>>>> Problem:
>>>> CodeCache::is_full() returns true if the non-nmethod code heap is full but we
>>>> can still store non-nmethod code in the non-profiled code heap and therefore
>>>> should not disable compilation (see comment 'fallback solution' in
>>>> CodeCache::allocate).
>>>>
>>>> Solution:
>>>> Adapt CodeCache::is_full() to not check the non-nmethod code heap. I also
>>>> fixed the CodeHeap is full warning to suggest increasing the non-profiled code
>>>> heap.
>>>>
>>>> Thanks,
>>>> Tobias
>>>
>