[9] RFR(S): 8060479: [TESTBUG] compiler/codecache/CheckSegmentedCodeCache.java test fails with product build

[David Chase]

Hello Tobias,

I am not a Reviewer, but that looks good to me.

I would add a comment to the bug itself making sure that you clarify what is going on.
Current text overuses the word “failure” without making it “clear” that the “failure” is a failure to fail;
that the test is verifies that the VM will exit with an error when the code cache is too small,
but in turns out that a release VM can run in a small enough code cache that the size used
by the test is in fact, not too small, and thus no error is seen, and thus the test is judged to have failed.

I’m not sure I was any better at explaining it :-(.
The intent is to make someone less puzzled when they look at this six months from now.

David

On 2014-10-15, at 10:19 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:

> Hi,
> 
> please review the following patch.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8060479
> Webrev: http://cr.openjdk.java.net/~thartmann/8060479/webrev.00/
> 
> Problem:
> The test CheckSegmentedCodeCache assumes that VM startup always fails with a ReservedCodeCacheSize of 1700K. This is not true for product builds (see 'min_code_cache_size' in 'CodeCache::initialize_heaps()').
> 
> Solution:
> Check for debug build and adjust minimum code cache size accordingly.
> 
> Testing:
> Failing test on JPRT.
> 
> Thanks,
> Tobias

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20141015/94e95a11/signature.asc>