RFR(S): 8028481: [TESTBUG] compiler/jsr292/CreatesInterfaceDotEqualsCallInfo.java should be in needs_nashorn test group

[Vladimir Kozlov]

Seems fine.

Thanks,
Vladimir K

On 10/20/14 8:53 AM, Sergei Kovalev wrote:
> Hi all
>
> Looking for second reviewer.
>
> On 17.10.2014 16:53, Vladimir Ivanov wrote:
>> Looks good.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 10/17/14, 4:02 PM, Sergei Kovalev wrote:
>>> Hi All,
>>>
>>> Please review the following patch.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028481
>>> Webrev: http://cr.openjdk.java.net/~vlivanov/kovalev/8028481/webrev.00/
>>>
>>> Problem:
>>> The test CreatesInterfaceDotEqualsCallInfo.java depends on nashorn
>>> extension and compact2 API. The extension is optional for embedded
>>> world. Therefore we should have an ability to exclude the test from
>>> execution. Also we should exclude it from compact1 execution.
>>>
>>> Solution:
>>> Two new groups are introduced: "needs_nashorn", "not_needs_nashorn".
>>> Also test added to a group "needs_compact2".
>>> I found that by mistake the test listed twice in a "hotspot_compiler_3"
>>> group. One of the copies removed.
>>>
>>> Testing:
>>> Groups content verified locally with jtreg.
>>>
>>
>>
>