[9] RFR(S): 8060479: [TESTBUG] compiler/codecache/CheckSegmentedCodeCache.java test fails with product build

[Tobias Hartmann]

Hi Vladimir,

I changed the fix as you suggested:
http://cr.openjdk.java.net/~thartmann/8060479/webrev.01/

The fix depends on JDK-8061443.

Thanks,
Tobias


On 17.10.2014 12:18, Tobias Hartmann wrote:
> Hi Vladimir,
> 
> On 17.10.2014 10:47, Vladimir Kozlov wrote:
>> CodeCacheMinimumUseSpace is different for Zero. There is WB API which returns
>> options value getUintxVMFlag() you can use to calculate value minSize.
> 
> Yes, but the flag is only available in debug builds. See 'Flag::find_flag':
> 
> 525	// Don't report notproduct and develop flags in product builds.
> 
> Calling getUintxVMFlag() throws a java.lang.NullPointerException with product
> builds. One solution would be to only perform this check for debug builds where
> we are able to compute the size. What do you think?
> 
>> 8046809 changes will change min_code_cache_size value again (removes
>> CodeCacheMinimumFreeSpace). Let Albert know to modify this test again.
> 
> I will do so.
> 
> Thanks,
> Tobias
> 
>> Thanks,
>> Vladimir
>>
>> On 10/17/14 12:00 AM, Tobias Hartmann wrote:
>>> Can I get another review for this?
>>>
>>> Thanks,
>>> Tobias
>>>
>>> On 15.10.2014 16:19, Tobias Hartmann wrote:
>>>> Hi,
>>>>
>>>> please review the following patch.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8060479
>>>> Webrev: http://cr.openjdk.java.net/~thartmann/8060479/webrev.00/
>>>>
>>>> Problem:
>>>> The test CheckSegmentedCodeCache assumes that VM startup always fails with a
>>>> ReservedCodeCacheSize of 1700K. This is not true for product builds (see
>>>> 'min_code_cache_size' in 'CodeCache::initialize_heaps()').
>>>>
>>>> Solution:
>>>> Check for debug build and adjust minimum code cache size accordingly.
>>>>
>>>> Testing:
>>>> Failing test on JPRT.
>>>>
>>>> Thanks,
>>>> Tobias