[9] RFR(S): 8061486: [TESTBUG] compiler/whitebox/ tests fail : must be osr_compiled (reappeared in nightlies)
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed Oct 22 21:24:05 UTC 2014
Looks good. Did you tested both Tiered and non-Tiered compilation?
Thanks,
Vladimir
On 10/22/14 7:49 AM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8061486
> Webrev: http://cr.openjdk.java.net/~thartmann/8061486/webrev.00/
>
> Problem:
> JDK-8060454 added a deoptimization before triggering the OSR compilation to
> avoid non-OSR compilations blocking OSR compilations.
> This is not sufficient because non-OSR compilations may also be triggered at
> backedges while the loop is being executed (if the backedge threshold is not yet
> reached but the invocation threshold is).
>
> Solution:
> Call warmup code from OSR triggering method, make sure non-OSR compilation is
> triggered and wait for completion until OSR compilation is triggered.
>
> Testing:
> - Failing test on Windows and Linux
> - Whitebox tests with different parameters on JPRT
>
> Thanks,
> Tobias
>
>
> [1] See 'AdvancedThresholdPolicy::method_back_branch_event()':
> // Use loop event as an opportunity to also check if there's been
> // enough calls.
>
More information about the hotspot-compiler-dev
mailing list