RFR(S): 8061250: serviceability/dcmd/compiler/CompilerQueueTest.java failed

Christian Thalinger christian.thalinger at oracle.com
Mon Oct 27 16:48:39 UTC 2014


Looks good except the indent is a bit off:

+   } else {
+           st->print("  ");
    }

> On Oct 27, 2014, at 9:46 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> 
>> On Oct 27, 2014, at 7:01 AM, Nils Eliasson <nils.eliasson at oracle.com <mailto:nils.eliasson at oracle.com>> wrote:
>> 
>> Hi,
>> 
>> Please review this change.
>> 
>> There was a small difference in logging depending on whether tiered was on or off. This made the parsing in the test fail. This problem was not caught earlier by a few reasons:
>> 
>> 1) We don't run the testing with a client VM very often
>> 2) Running server with tiered off don't compile much and the queue is mostly empty
>> 3) When runnning with Xcomp compilation is synchronous so the queue is always empty
>> 
>> The change includes a small fix for consistent logging indentation regardless of tiering, and adding a non-tiered test-case.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8061250 <https://bugs.openjdk.java.net/browse/JDK-8061250>
>> Rev: file:///home/neliasso/repos/jdk9_hs-comp/hotspot/8061250/webrev.02/index.html <file:///home/neliasso/repos/jdk9_hs-comp/hotspot/8061250/webrev.02/index.html>
> 
> WEB-rev: http://cr.openjdk.java.net/~neliasso/8061250/webrev.02/ <http://cr.openjdk.java.net/~neliasso/8061250/webrev.02/>
> 
> ;-)
> 
>> 
>> Thanks,
>> Nils

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20141027/ee76c989/attachment.html>


More information about the hotspot-compiler-dev mailing list