RFR(S): 8061250: serviceability/dcmd/compiler/CompilerQueueTest.java failed

[Nils Eliasson]

Hi Vladimir,

It is human readable output that differs unnecessarily with tiered or 
not. This is only a sanity test for that output (otherwise I would have 
use a structured output).

I implemented a workaround in the test instead.

Webrev: http://cr.openjdk.java.net/~neliasso/8061250/webrev.04

We don't need to add a test case for C1. The tiered case covers that well.

Regards,
Nils

On 2014-10-27 18:02, Vladimir Kozlov wrote:
> Correct webrev link:
>
> http://cr.openjdk.java.net/~neliasso/8061250/webrev.02/
>
> Hi Nils,
>
> Indention of changed code is incorrect in compileBroker.cpp.
>
> Output parser should not relay on particular spacing in output. Is it 
> hard to fix? I am not comfortable that you changing output of 
> non-tiered code just to workaround a problem in a tool.
>
> Do you think we should also test only C1 compilation when Tiered is 
> enabled?:
>
>  -XX:+TieredCompilation -XX:TieredStopAtLevel=1
>
> Thanks,
> Vladimir
>
> On 10/27/14 7:01 AM, Nils Eliasson wrote:
>> Hi,
>>
>> Please review this change.
>>
>> There was a small difference in logging depending on whether tiered was
>> on or off. This made the parsing in the test fail. This problem was not
>> caught earlier by a few reasons:
>>
>> 1) We don't run the testing with a client VM very often
>> 2) Running server with tiered off don't compile much and the queue is
>> mostly empty
>> 3) When runnning with Xcomp compilation is synchronous so the queue is
>> always empty
>>
>> The change includes a small fix for consistent logging indentation
>> regardless of tiering, and adding a non-tiered test-case.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8061250
>> Rev:
>> file:///home/neliasso/repos/jdk9_hs-comp/hotspot/8061250/webrev.02/index.html 
>>
>>
>>
>> Thanks,
>> Nils