RFR(XS) : 8036913 : make DeoptimizeALot dependent on number of threads

[Igor Ignatyev]

On 10/30/2014 03:29 AM, Vladimir Kozlov wrote:
> I thought about something like next comment in places where you add
> division:
yeah I also thought to add smth like that, but your "add this 
explanation as a comment" confused me.

>
>    void InterfaceSupport::zombieAll() {
>      // This method is called by all threads when a thread make
>      // transition to VM state (for example, runtime calls).
>      // Divide number of calls by number of threads to avoid
>      // dependence of ZombieAll events on number of threads.
>      int value = zombieAllCounter / Threads::number_of_threads();
added almost this comment

http://cr.openjdk.java.net/~iignatyev/8036913/webrev.02/
>
> Thanks,
> Vladimir
>
> On 10/29/14 5:02 PM, Igor Ignatyev wrote:
>> Vladimir/Aleksey,
>>
>> thanks for review.
>>
>> the updated webrev w/ the comment:
>> http://cr.openjdk.java.net/~iignatyev/8036913/webrev.01/
>> 11 lines changed: 3 ins; 3 del; 5 mod;
>>
>> Igor
>>
>> On 10/29/2014 05:48 PM, Vladimir Kozlov wrote:
>>> Igor,
>>>
>>> On 10/29/14 6:49 AM, Igor Ignatyev wrote:
>>>> Aleksey,
>>>>
>>>> zombie/deoptimizeAllCounter are invocation counters of corresponding
>>>> function and not counters of the actually happened
>>>> events. so they should be incremented on each invocation of the
>>>> function.
>>>
>>> Please, add this explanation as a comment so it would be clear why you
>>> divide by number of threads.
>>> Changes are fine with that.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>>>
>>>> Thanks
>>>> Igor
>>>>
>>>> On 10/28/2014 09:41 PM, Aleksey Shipilev wrote:
>>>>> On 28.10.2014 21:22, Igor Ignatyev wrote:
>>>>>> http://cr.openjdk.java.net/~iignatyev/8036913/webrev.00/
>>>>>> 8 lines changed: 2 ins; 2 del; 4 mod;
>>>>>
>>>>> Looks good.
>>>>>
>>>>>> + zombieAllCounter incrementation is moved out of if-else to be
>>>>>> aligned
>>>>>> w/ deoptimizeAllCounter
>>>>>
>>>>> Shouldn't it be in reverse, i.e. deoptimizeAllCounter to be moved in
>>>>> the
>>>>> block? I would think counting the _successful_ deoptimizeAll/zombieAll
>>>>> events is more useful.
>>>>>
>>>>> -Aleksey.
>>>>>
>>>>>