[9] RFR (L): JDK-8055904: Develop tests on newly added command line options related to SHA intrinsics

[James Cheng]

Hi Flipp,

Thanks for making the changes.

Regards,
-James

On Sep 1, 2014, at 12:59 AM, Filipp Zhinkin <filipp.zhinkin at oracle.com> wrote:

> Hi James,
> 
> thank you for looking at it!
> 
> I fixed all issues listed below. Here is the updated webrev:
> http://cr.openjdk.java.net/~fzhinkin/8055904/webrev.01/
> 
> Also, I reran tests on different platforms to ensure that they still work fine.
> 
> Thanks,
> Filipp.
> 
> On 29.08.2014 23:51, james cheng wrote:
>> Hi Filipp,
>> 
>> I saw some glitches:
>> 
>> http://cr.openjdk.java.net/~fzhinkin/8055904/webrev.00/test/compiler/intrinsics/sha/cli/SHAOptionsBase.java.html 
>>  50             = "SHA256 instruction.*is not available on this CPU.";
>>  52             = "SHA512 instruction.*is not available on this CPU.";
>>                                      ^^
>> 
>> http://cr.openjdk.java.net/~fzhinkin/8055904/webrev.00/test/compiler/intrinsics/sha/cli/testcases/UseSHASpecificTestCaseForSupportedSparcCPU.java.html 
>>  49         // all UseSHA*Intrinsics options were turned on.
>>                                                          ^^
>> 
>> http://cr.openjdk.java.net/~fzhinkin/8055904/webrev.00/test/compiler/intrinsics/sha/cli/TestUseSHA1IntrinsicsOptionOnUnsupportedCPU.java.html 
>>  42 SHAOptionsBase.USE_SHA512_INTRINSICS_OPTION),
>>                                                   ^^^
>> 
>> http://cr.openjdk.java.net/~fzhinkin/8055904/webrev.00/test/compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java.html 
>>  42 SHAOptionsBase.USE_SHA512_INTRINSICS_OPTION),
>>                                                   ^^^
>> 
>> Thanks,
>> -James
>> 
>> On 8/29/2014 11:49 AM, Filipp Zhinkin wrote:
>>> Hi all,
>>> 
>>> please review tests on processing of SHA-related command line options.
>>> 
>>> Tests verify:
>>> - startup warnings;
>>> - default values;
>>> - ability to enable/disable options on supported CPUs;
>>> - that options are always disabled on unsupported CPUs;
>>> - relations between UseSHA and UseSHA*Intrinsics options.
>>> 
>>> Each particular test constructed from several generalized testcases,
>>> each of which verifies that several assertions hold in specific environment,
>>> like availability of all SPARC's sha* instruction, availability of only several
>>> of then or execution on X86 CPU.
>>> 
>>> Each test case will be executed only if all its preconditions have been met.
>>> Otherwise, the test case will be skipped from execution.
>>> 
>>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8055904
>>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8055904/webrev.00/
>>> Testing: manual, automated.
>>> 
>>> Note that this change depends on the fix for JDK-8055903 [1].
>>> RFR for JDK-8055903 [2] was published earlier today.
>>> 
>>> Thanks,
>>> Filipp.
>>> 
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8055903
>>> [2] http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-August/015337.html
>