RFR(S): 8056124 Hotspot should use PICL interface to get cacheline size on SPARC

Igor Veresov igor.veresov at oracle.com
Wed Sep 3 17:45:01 UTC 2014


Hi Morris,

Thanks for looking at it.

_L1_data_cache_line_size is a field of VM_Version (shared/vm/runtime/vm_version.hpp). It is used via it’s accessors VM_Version::L1_data_cache_line_size() in ObjectMonitor::sanity_checks() and down in ObjectSynchronizer::sanity_checks().

igor 

On Sep 3, 2014, at 8:59 AM, Morris Meyer <morris.meyer at oracle.com> wrote:

> Igor,
> 
> It looks like you are no longer using _L1_data_cache_line_size but still keeping functionality to generate the value.
> 
> Everything else looks good.
> 
> Not a reviewer.
> 
>        --mm
> 
> 
> On 9/3/14, 5:04 AM, Igor Veresov wrote:
>> Use libpicl on Solaris/SPARC to get cache line sizes.
>>  JBS: https://bugs.openjdk.java.net/browse/JDK-8056124
>> Webrev: http://cr.openjdk.java.net/~iveresov/8056124/webrev.00/
>> Testing: manual tests, jprt
>> 
>> Thanks!
>> igor
> 



More information about the hotspot-compiler-dev mailing list