RFR(M): 8054889 - Additional Compiler Diagnostic commands

[Nils Eliasson]

Hi,

Thanks for your feedback Vladimir.

New webrev here http://cr.openjdk.java.net/~neliasso/8054889/webrev.07/

//Nils


On 2014-09-05 19:06, Vladimir Kozlov wrote:
> On 9/5/14 8:40 AM, David Chase wrote:
>> Nils,
>>
>> on codeCache.hpp, I see a comment "// Dcmd"
>> And other places I see Dcmd used in class/method names, but
>> I have to know or guess that Dcmd is Diagnostic Command,
>> so maybe the comment should say "// Dcmd (Diagnostic commands)”
>
> Yes, please, decode mnemonic.
>
>>
>> Picky, I know, but I’ve spent too much time lost in the sources 
>> trying to figure
>> out what was supposed to be going on.
>>
>> Are we supposed to have @author tags on our (test) sources?
>> I thought I heard we were not, but that’s hardly definitive.
>
> We are not. Only for external contributions.
>
> Vladimir
>
>>
>> David
>>
>>>>> Hi,
>>>>>
>>>>> This fix introduces three new diagnostic commands and 
>>>>> corresponding tests. The commands are Compiler.queue for printing 
>>>>> the contents of the compiler queue, Compiler.codelist for printing 
>>>>> all nmethods in the codecache and Compiler.codecache for printing 
>>>>> an informational code cache summary.
>>>>>
>>>>> Description here:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8054889
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~neliasso/8054889/webrev.02/
>>>>>
>>>>> Thanks,
>>>>> Nils Eliasson
>>>>
>>>
>>