8038098: test/compiler/codegen/LoadWithMask2.java tags changes to also test C1 inlining

Filipp Zhinkin filipp.zhinkin at oracle.com
Mon Sep 15 12:01:06 UTC 2014


Hi Jane,

mail's summary does not match the bug's name.

As about your fix: I thought that such configs as client/server
and tired/non-tired should be rotated in nightly, aren't it?

Maybe it does more sense to just remove '-server' option?
With '-client' the test may fail during test runs that were started
with some C2-specific options, like UseRTMLocking.

Thanks,
Filipp.

On 09/15/2014 03:42 PM, Evgeniya Stepanova wrote:
> Hi all!
>
> Please review fix for 8038098
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8038098
>
> Problem: Since we have inlining in C1 now, we should check that issue 8031743 
> will not appear in C1.
> Solution: Added one more run in test for C1 inlining checking
>
> A am also need someone to push changes.
>
> Diff is in the attachments.
> I've also included diff to this letter since it is very small.
>
>
> Thanks,
> Jane
>
> diff -r 087443edb74a test/compiler/codegen/LoadWithMask2.java
> --- a/test/compiler/codegen/LoadWithMask2.java    Mon Sep 15 08:08:22 2014 +0200
> +++ b/test/compiler/codegen/LoadWithMask2.java    Mon Sep 15 14:35:50 2014 +0400
> @@ -26,6 +26,7 @@
>   * @bug 8031743
>   * @summary loadI2L_immI broken for negative memory values
>   * @run main/othervm -server -Xbatch -XX:-TieredCompilation 
> -XX:CompileCommand=compileonly,*.foo* LoadWithMask2
> + * @run main/othervm -client -Xbatch -XX:+TieredCompilation 
> -XX:CompileCommand=compileonly,*.foo* LoadWithMask2
>   *
>   */
>  public class LoadWithMask2 {



More information about the hotspot-compiler-dev mailing list