[9] RFR(S): 8058712: [TESTBUG] serviceability/dcmd/CodeCacheTest.java fails with java.lang.Exception

[Vladimir Kozlov]

Good.

Thanks,
Vladimir

On 9/19/14 12:31 AM, Tobias Hartmann wrote:
> Hi Vladimir,
>
> thanks for the review.
>
> On 18.09.2014 22:46, Vladimir Kozlov wrote:
>> Changes look fine but, please, add second @run command to test both casese:
>>
>>   * @run main/othervm -XX:+SegmentedCodeCache CodeCacheTest
>>   * @run main/othervm -XX:-SegmentedCodeCache CodeCacheTest
>
> Done. New webrev:
> http://cr.openjdk.java.net/~thartmann/8058712/webrev.01/
>
> Thanks,
> Tobias
>
>>
>> Nightly testing has both Tiered and non-Tiered configurations so you don't need @run commands for that.
>>
>> Thanks,
>> Vladimir
>>
>> On 9/18/14 3:28 AM, Tobias Hartmann wrote:
>>> Hi,
>>>
>>> please review the following patch.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8058712
>>> Webrev: http://cr.openjdk.java.net/~thartmann/8058712/webrev.00/
>>>
>>> Problem:
>>> The test ' serviceability/dcmd/CodeCacheTest.java' recently added by JDK-8054889 checks the output of the
>>> Compiler.codecache jcmd command. With the segmented code cache this output changed and the test needs to be adapted.
>>> Further, the test fails with -Xint because it expects nmethods > 0 and compilation being enabled.
>>>
>>> Solution:
>>> The test is changed to check the output according to the number of available code segments.
>>>
>>> Thanks,
>>> Tobias
>