RFR(S): 8058891: serviceability/dcmd/CodelistTest.java - fails on all platforms

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Sep 23 21:24:05 UTC 2014


On 9/23/14 6:14 AM, Nils Eliasson wrote:
> Hi,
>
> Please review this small fix. It contains:
>
> 1) Adding compiler dcmd tests to TEST.groups/hotspot_compiler_3

I think they belong to hotspot_serviceability group. Please, move it there.

> 2) Moving compiler dcmd tests to subfolder compiler and adding @library
> tag to find and build DcmdUtil

Was MethodIdentifierParser.java just moved and no change was done in it?

> 3) Fixing CompilerQueueTest to work in client, vintage server (no
> tiered), and with interpreter only

Could you explain 3) changes? I see only new throws which will causes 
test failure.

Should we also test interpreter mode in CodeCacheTest.java?:

@run main/othervm -Xint -XX:+SegmentedCodeCache CodeCacheTest


> 4) Preventing CodelistTest from trying to reflect MethodHandles

Explain change.

Thanks,
Vladimir

>
> Tests run: Test group hotspot_compiler_3 on the 9 major platforms.
>
> https://bugs.openjdk.java.net/browse/JDK-8058891
> http://cr.openjdk.java.net/~neliasso/8058891/webrev.03/
>
> Thanks,
> Nils


More information about the hotspot-compiler-dev mailing list