RFR(S): 8058891: serviceability/dcmd/CodelistTest.java - fails on all platforms

[Christian Thalinger]

On Sep 29, 2014, at 5:07 AM, David Chase <david.r.chase at oracle.com> wrote:

> Small-r reviewer here:
> 
> Is it too picky to ask for a more accurate comment in CodeListTest.java

Not, it is not.  We should take good care of our comments; keep them up-to-date and as precise as possible.  We will thank ourselves in the future.

> 
>            // skip inits and clinits - they can not be reflected
> 
> MethodHandles are also skipped, and for the same reason.
> Otherwise fine.
> 
> David
> 
> On 2014-09-26, at 9:17 AM, Nils Eliasson <nils.eliasson at oracle.com> wrote:
> 
>> Can I please have a second review,
>> 
>> Regards,
>> //Nils
>> 
>> On 2014-09-23 15:14, Nils Eliasson wrote:
>>> Hi,
>>> 
>>> Please review this small fix. It contains:
>>> 
>>> 1) Adding compiler dcmd tests to TEST.groups/hotspot_compiler_3
>>> 2) Moving compiler dcmd tests to subfolder compiler and adding @library tag to find and build DcmdUtil
>>> 3) Fixing CompilerQueueTest to work in client, vintage server (no tiered), and with interpreter only
>>> 4) Preventing CodelistTest from trying to reflect MethodHandles
>>> 
>>> Tests run: Test group hotspot_compiler_3 on the 9 major platforms.
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8058891
>>> http://cr.openjdk.java.net/~neliasso/8058891/webrev.03/
>>> 
>>> Thanks,
>>> Nils
>> 
>