[9] RFR(S): 8059468: Fix PrintCodeCache output changed by JDK-8059137

Albert Noll albert.noll at oracle.com
Tue Sep 30 12:44:31 UTC 2014


Looks good to me (not a reviewer).

Minor nit (which need not be fixed): Wouldn't the naming be more 
consistent if we call the non-method heap non-nmethod heap?

*-    add_heap(non_method_space, "Code  Heap 'non-methods'", init_non_method_size, CodeBlobType::NonMethod);*


Best,
Albert

On 09/30/2014 02:34 PM, Tobias Hartmann wrote:
> Hi,
>
> please review this small patch that changes the output of 
> -XX:+PrintCodeCache accidentally changed by JDK-8059137 [1] from 'Code 
> Cache' back to 'CodeCache' because some tests depend on the output.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8059468
> Webrev: http://cr.openjdk.java.net/~thartmann/8059468/webrev.00/
>
> Thanks,
> Tobias
>
> [1] http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/3af889385bcf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140930/01eb0b22/attachment-0001.html>


More information about the hotspot-compiler-dev mailing list