RFR(S) 8076968: PICL based initialization of L2 cache line size on some SPARC systems is incorrect

[Igor Veresov]

Vitaly,

Thanks, others already noted the typo.
The comment means that we memoize the result of bruteforcing of the name of the property. I’m quite sure what is the confusion? What would you like it to say?

igor 

> On Apr 6, 2015, at 5:13 PM, Vitaly Davidovich <vitalyd at gmail.com> wrote:
> 
> Hi Igor,
> 
> // One the first visit determine the name of the l2 cache line size property and memoize it
> 
> Typo - should be "On the first ..." I presume.
> 
> Also, that code doesn't just memoize the property name, it also appears to actually probe for and set the value - worthwhile to update the comment?
> 
> sent from my phone
> 
> On Apr 6, 2015 8:00 PM, "Igor Veresov" <igor.veresov at oracle.com <mailto:igor.veresov at oracle.com>> wrote:
> Thanks, Vladimir!
> 
> igor
> 
> > On Apr 6, 2015, at 3:59 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>> wrote:
> >
> > Good.
> >
> > Thanks,
> > Vladimir
> >
> > On 4/6/15 3:46 PM, Igor Veresov wrote:
> >> The L2 data cache line size property can be name either "l2-cache-line-size” or “l2-dcache-line-size”. We have to try them both.
> >>
> >> Webrev: http://cr.openjdk.java.net/~iveresov/8076968/webrev.00/ <http://cr.openjdk.java.net/~iveresov/8076968/webrev.00/>
> >>
> >> Thanks,
> >> igor
> >>
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150406/258f56b1/attachment.html>