[9] RFR(S): 8068945: Use RBP register as proper frame pointer in JIT compiled code on x86

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Apr 22 21:21:26 UTC 2015


Okay. We can leave the flag off by default but ask SQE to add it to 
flags rotation in our Nightly testing. This way we will have test 
coverage for both cases. Igor?

Vladimir

On 4/22/15 2:16 PM, Aleksey Shipilev wrote:
> On 04/23/2015 12:09 AM, Vladimir Kozlov wrote:
>> You can always find a test which will regress with any changes :)
>
> Yes, and the job for performance guys is to say which tests are really
> important, and which can be disregarded ;)
>
>> We need to enable the flag by default for now to test new code path.
>> As I said we can switch it off later - it may be not final value which
>> will be shipped.
>
> I fully dig the idea of running the tests with a flag set on.
>
> IMO, if this thing comes in enabled by default, there should be a shadow
> high-priority bug saying "Figure out if we need to to disable $flag", so
> it does not slip from the release radar.
>
> -Aleksey.
>
>


More information about the hotspot-compiler-dev mailing list