RFR (XL): 8075492: update IGV in hs-comp

Michael Haupt michael.haupt at oracle.com
Wed Apr 29 14:40:35 UTC 2015


Hi Roland,

> Am 29.04.2015 um 16:36 schrieb Roland Westrelin <roland.westrelin at oracle.com>:
>> Webrev: http://cr.openjdk.java.net/~mhaupt/8075492/webrev.00
> 
> Why do you need the change to BranchData::print_data_on()?

the extra line break otherwise emitted would confuse IGV's input parsing logic, generating a plethora of warning messages.

> Otherwise I think it’s good. I only looked at the hotspot changes and I don’t see how the IGV changes themselves can be reviewed. I also gave it a quick try and spotted no problems.

Thanks,

Michael

-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | HotSpot Compiler Team 
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150429/6dd685bb/attachment.html>


More information about the hotspot-compiler-dev mailing list