Re: [9] RFR(XS): 8133625: src/share/vm/opto/compile.hpp:96: error: integer constant is too large for ‘long’ type

[Vladimir Kozlov]

Looks good.

Thanks,
Vladimir

On 8/18/15 10:02 AM, Zoltan Majo wrote:
> Hi,
>
>
> please review the following patch for JDK-8133625.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8133625
>
>
> Problem: On certain platforms (e.g., x86_32) and with certain GCC versions (e.g., GCC-4.4), the following compilation
> error appears:
>
> hotspot/src/share/vm/opto/compile.hpp:96: error: integer constant is too large for ‘long’ type
>
>
> Solution: Fold the constant on line 96 of compile.hpp into CONST64() (as suggested in bug description). Also slightly
> changed the comments for CONST64().
>
> Webrev:
> http://cr.openjdk.java.net/~zmajo/8133625/webrev.00/
>
> Testing:
> - JPRT run with testset hotspot; all tests pass;
> - build locally with GCC-4.4 (fails without patch, passes with patch).
>
> Thank you and best regards,
>
>
> Zoltan
>