RFC (S) 8076758: new StringBuilder().append(String).toString() should be recognized by OptimizeStringConcat

[Tobias Hartmann]

Hi Aleksey,

looks good.

Best,
Tobias

On 31.08.2015 13:32, Aleksey Shipilev wrote:
> Thanks for taking a look, Tobias!
> 
> On 08/31/2015 08:24 AM, Tobias Hartmann wrote:
>> I don't think you need the has_offset_field() check because the
>> String.offset field was removed long time ago. We're going to remove
>> the legacy VM side code with the compact strings JEP [1].
> 
> Okay, removed. I actually wondered about that, but decided to make the
> code synonymous to the existing one. Anyway:
>  http://cr.openjdk.java.net/~shade/8076758/webrev.01/
> 
>> Otherwise it looks good. Please also execute the following test [2]
>> from compact strings because it contains some string concat
>> correctness checks.
> 
> Done, the test passes.
> 
>> [1] http://hg.openjdk.java.net/jdk9/sandbox/hotspot/rev/2da46f06bfba
>> [2[ http://hg.openjdk.java.net/jdk9/sandbox/hotspot/file/b50bebd0085b/test/compiler/intrinsics/string/TestStringIntrinsics.java
> 
> Thanks,
> -Aleksey
> 
>