RFR (S): 8144529: [JVMCI] compiler/jvmci/errors/TestInvalidCompilationResult.java fails to compile after JDK-8143730

Christian Thalinger christian.thalinger at oracle.com
Wed Dec 2 21:53:54 UTC 2015


https://bugs.openjdk.java.net/browse/JDK-8144529 <https://bugs.openjdk.java.net/browse/JDK-8144529>

I forgot to fix some tests.

diff -r 8578909eeef4 test/compiler/jvmci/errors/CodeInstallerTest.java
--- a/test/compiler/jvmci/errors/CodeInstallerTest.java	Thu Nov 26 10:38:33 2015 +0000
+++ b/test/compiler/jvmci/errors/CodeInstallerTest.java	Wed Dec 02 10:59:39 2015 -1000
@@ -68,6 +68,7 @@ public class CodeInstallerTest {
     }
 
     protected void installCode(CompilationResult result) {
+        result.close();
         codeCache.addCode(dummyMethod, result, null, null);
     }
 
diff -r 8578909eeef4 test/compiler/jvmci/errors/TestInvalidCompilationResult.java
--- a/test/compiler/jvmci/errors/TestInvalidCompilationResult.java	Thu Nov 26 10:38:33 2015 +0000
+++ b/test/compiler/jvmci/errors/TestInvalidCompilationResult.java	Wed Dec 02 10:59:39 2015 -1000
@@ -219,13 +219,6 @@ public class TestInvalidCompilationResul
     }
 
     @Test(expected = JVMCIError.class)
-    public void testUnknownInfopointReason() {
-        CompilationResult result = createEmptyCompilationResult();
-        result.addInfopoint(new Infopoint(0, null, InfopointReason.UNKNOWN));
-        installCode(result);
-    }
-
-    @Test(expected = JVMCIError.class)
     public void testInfopointMissingDebugInfo() {
         CompilationResult result = createEmptyCompilationResult();
         result.addInfopoint(new Infopoint(0, null, InfopointReason.METHOD_START));
diff -r 8578909eeef4 test/compiler/jvmci/events/JvmciNotifyInstallEventTest.java
--- a/test/compiler/jvmci/events/JvmciNotifyInstallEventTest.java	Thu Nov 26 10:38:33 2015 +0000
+++ b/test/compiler/jvmci/events/JvmciNotifyInstallEventTest.java	Wed Dec 02 10:59:39 2015 -1000
@@ -106,13 +106,12 @@ public class JvmciNotifyInstallEventTest
         HotSpotCompilationRequest compRequest = new HotSpotCompilationRequest(method, -1, 0L);
         // to pass sanity check of default -1
         compResult.setTotalFrameSize(0);
+        compResult.close();
         codeCache.installCode(compRequest, compResult, /* installedCode = */ null, /* speculationLog = */ null,
                 /* isDefault = */ false);
         Asserts.assertEQ(gotInstallNotification, 1,
                 "Got unexpected event count after 1st install attempt");
         // since "empty" compilation result is ok, a second attempt should be ok
-        compResult = new CompilationResult(METHOD_NAME); // create another instance with fresh state
-        compResult.setTotalFrameSize(0);
         codeCache.installCode(compRequest, compResult, /* installedCode = */ null, /* speculationLog = */ null,
                 /* isDefault = */ false);
         Asserts.assertEQ(gotInstallNotification, 2,

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151202/73ff4416/attachment.html>


More information about the hotspot-compiler-dev mailing list