RFR (M): 8143925: Enhancing CounterMode.crypt() for AES

[Kharbas, Kishor]

Thanks Vladimir for the feedback!

I have updated the jbs entry with the new patch.

JDK changes : added range checks in the JDK using additional methods.
Hotspot changes : renamed the UseCTRAESIntrinsics flag to UseAESCTRIntrinsics

Further review and feedback is appreciated!

- Kishor

-----Original Message-----
From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com] 
Sent: Tuesday, December 01, 2015 5:32 PM
To: Kharbas, Kishor; hotspot-compiler-dev at openjdk.java.net
Subject: Re: RFR (M): 8143925: Enhancing CounterMode.crypt() for AES

Hotspot changes seems fine. But JDK changes should have additional method for range checks - this is new requirement for intrinsics which access arrays. See, for example, cryptBlockCheck() in AESCrypt.java.

Thanks,
Vladimir

On 11/24/15 2:33 PM, Kharbas, Kishor wrote:
> Hello all,
>
> I request the community to review a patch for enhancing
> CounterMode.crypt() for AES. This patch defines intrinsic for
> CounterMode.crypt() to leverage the parallel nature of AES in Counter
> (CTR) Mode.
>
> This is achieved by operating on 6 blocks in parallel to issue 
> independent x86 AES-NI instructions and keep the CPU pipeline full.
>
> Testing on micro-benchmark has shown a speedup of 4x-6x.
>
> Bug id:
>
>     https://bugs.openjdk.java.net/browse/JDK-8143925
>
> Webrev:
>
>    hotspot: 
> http://cr.openjdk.java.net/~mcberg/8143925/hotspot/webrev.02/
>
>    jdk: http://cr.openjdk.java.net/~mcberg/8143925/jdk/webrev.01/
>
> Much appreciated!
>
> Kishor Kharbas
>