RFR(S): 8140667: CompilerControl: tests incorrectly set states for excluded methods

Pavel Punegov pavel.punegov at oracle.com
Mon Dec 7 12:20:50 UTC 2015


Thanks for review, Vladimir.

Pavel.

> On 01 Dec 2015, at 03:57, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Good.
> 
> Thanks,
> Vladimir
> 
> On 11/25/15 1:58 PM, Pavel Punegov wrote:
>> Please review this fix for tests.
>> 
>> Issue: CompilerOracle checks CompileCommands for being in excluded list
>> or compileonly list while deciding to compile method or not.
>> CompilerControl test framework assumes that these commands override each
>> other.
>> 
>> This fix makes tests to behave in the same manner as CompilerOracle
>> does. Fix adds an internal singleton class to AbstractCommandBuilder
>> used for creating a test commands (-XX:CompileCommand and
>> CompileCommandFile)
>> 
>> webrev: http://cr.openjdk.java.net/~ppunegov/8140667/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8140667
>> 
>> — Thanks,
>> Pavel Punegov
>> 



More information about the hotspot-compiler-dev mailing list