RFR(M): 8144466: ppc64: fix argument passing through opto stubs.
Lindenmaier, Goetz
goetz.lindenmaier at sap.com
Wed Dec 9 07:35:01 UTC 2015
Hi Vladimir,
thanks a lot for review and sponsoring!
Best regards,
Goetz.
> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> Sent: Dienstag, 8. Dezember 2015 18:55
> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-compiler-
> dev at openjdk.java.net
> Subject: Re: RFR(M): 8144466: ppc64: fix argument passing through opto
> stubs.
>
> Okay. I need to get closed changes reviewed before push.
>
> Thanks,
> Vladimir
>
> On 12/8/15 1:41 AM, Doerr, Martin wrote:
> > Hi Vladimir,
> >
> > C1 does the int to long conversions in the platform code. I didn't find any
> missing conversion in the C1 code.
> > The only C1 issue with respect to runtime calls is 8143817 for which I'll send
> out another email.
> >
> > Best regards,
> > Martin
> >
> >
> > -----Original Message-----
> > From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> bounces at openjdk.java.net] On Behalf Of Vladimir Kozlov
> > Sent: Dienstag, 8. Dezember 2015 02:18
> > To: hotspot-compiler-dev at openjdk.java.net
> > Subject: Re: RFR(M): 8144466: ppc64: fix argument passing through opto
> stubs.
> >
> > Looks fine. Do you need to do anything for C1 which you have now?
> >
> > Thanks,
> > Vladimir
> >
> > On 12/7/15 7:12 AM, Lindenmaier, Goetz wrote:
> >> Hi,
> >>
> >> I need to fix the calls to runtime for ppc because it expects int
> >>
> >> being properly sign extended to long.
> >>
> >> In 8086069, we tried to push this to the platform code, but for
> >>
> >> opto stubs this is not possible.
> >>
> >> Please review this change. I please need a sponsor.
> >>
> >> http://cr.openjdk.java.net/~goetz/webrevs/8144466-
> ppcOptoStubs/webrev.00/
> >>
> >> The change comes with a corresponding test.
> >>
> >> I also added a test for a problem we fixed before, where
> >>
> >> floating point args were passed wrong.
> >>
> >> Best regards,
> >>
> >> Goetz.
> >>
More information about the hotspot-compiler-dev
mailing list