RFR: 8144856 (XS): Fix assert in CompiledStaticCall::set_to_interpreted

Tobias Hartmann tobias.hartmann at oracle.com
Fri Dec 11 10:18:21 UTC 2015


Hi Jamsheed,

looks good to me.

Best,
Tobias

On 11.12.2015 10:37, Jamsheed C m wrote:
> Hi All,
> 
> 
> Summary: Assert code in CompiledStaticCall::set_to_interpreted is fixed. Previous implementation did multiple reads for multiple valid state check in same assert for the MT safe updates that can happen from other threads. This could cause bogus failures as after each read state could have changed. As a fix to this, made the code to read the value at once.
> 
> Bug:https://bugs.openjdk.java.net/browse/JDK-8144856
> 
> webrev: http://cr.openjdk.java.net/~thartmann/8144856/webrev.00/
> 
> Testing: jprt hotspot.
> 
> Thanks and Best Regards,
> Jamsheed
> 
> 


More information about the hotspot-compiler-dev mailing list