RFR(S/M): 8144246: CompilerControl: adding lots of directives via jcmd may produce OOM crash
Pavel Punegov
pavel.punegov at oracle.com
Tue Dec 15 15:09:36 UTC 2015
Nils, thanks for updating tests. It looks good
Pavel.
> On 15 Dec 2015, at 18:04, Nils Eliasson <nils.eliasson at oracle.com> wrote:
>
> Thank you Vladimir!
>
> I added a test update to the webrev to limit the stress test to 1000 directives.
>
> http://cr.openjdk.java.net/~neliasso/8144246/webrev.02/
>
> Best regards,
> //Nils
>
> On 2015-12-14 23:59, Vladimir Kozlov wrote:
>> Looks good.
>>
>> Thanks,
>> Vladimir
>>
>> On 12/14/15 6:53 AM, Nils Eliasson wrote:
>>> Hi,
>>>
>>> Please review this minor change. It introduced a limit to how many
>>> directives can be added. The limit can be controlled by the diagnostic
>>> flag CompilerDirectivesLimit. For normal use it would be very unusual to
>>> have more than a few directives.
>>>
>>> The Flag PrintCompilerDirectives was changed to CompilerDirectivesPrint
>>> to have a consistent naming for all directives flag. This is a new flag
>>> and is not used anywhere yet.
>>>
>>> Testing:
>>> All the compiler control tests will have been run before submit.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8144246
>>> Webrev: http://cr.openjdk.java.net/~neliasso/8144246/webrev.01/
>>>
>>> Regards,
>>> Nils
>>>
>
More information about the hotspot-compiler-dev
mailing list